Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove double click to rename feature as its bad ux #1231

Merged
merged 2 commits into from
Dec 12, 2023
Merged

fix: remove double click to rename feature as its bad ux #1231

merged 2 commits into from
Dec 12, 2023

Conversation

abose
Copy link
Member

@abose abose commented Dec 12, 2023

  • Double click to rename is a mac feature in finder. This is not available in windows or linux file explorers.
  • Brackets implementing it across all os is confusing to the user in windows and linux when the user doesnt expect the file to be renamed on double clicked.
  • On mac, other code editors like vscode do not have this feature. So it will be confusing workflow to mac devs too.
  • Also for larger files, the file load delay will interfear with the double click timers and it will confuse the user as to weather the double click worked to rename or to open the file and ad to working set.

@phoenixide
Copy link
Member

Thank You for making this pull request.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@phoenixide
Copy link
Member

Thank You for making this pull request.

@abose abose merged commit a771bfb into main Dec 12, 2023
17 checks passed
@abose abose deleted the dd branch December 12, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants